Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format-13 #3235

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

clang-format-13 #3235

wants to merge 4 commits into from

Conversation

averinevg
Copy link
Collaborator

Update to clang-format-13

@junliume
Copy link
Collaborator

junliume commented Sep 4, 2024

Update to clang-format-13

@averinevg why version 13? In another discussion thread I thought it was mentioned that we need to update to the default version in Ubuntu 22.04?
Update: e.g. why not clang-format-15? ref: #3213 (comment)

@averinevg
Copy link
Collaborator Author

averinevg commented Sep 5, 2024

Update to clang-format-13

@averinevg why version 13? In another discussion thread I thought it was mentioned that we need to update to the default version in Ubuntu 22.04? Update: e.g. why not clang-format-15? ref: #3213 (comment)

@junliume If we update to clang-format-15 right away, there will be too many changes, I tried. Let's move step by step.

Default version in Ubuntu 22.04 is clang-format-14, but it is possible to install clang-format-15 OOTB.

@junliume
Copy link
Collaborator

junliume commented Sep 6, 2024

@averinevg @CAHEK7 Let's place this PR after next staging :) It involves lots of changed files, and CK needs to change too. and we want to check what the rest of ROCm is using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants